<html>
<head><meta charset="utf-8"><title>Question: -label +label ? · t-release/triage · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/index.html">t-release/triage</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html">Question: -label +label ?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="224584231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224584231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224584231">(Jan 30 2021 at 13:03)</a>:</h4>
<p>Hey triage team!</p>
<p>I have a question: I often see a someone from triage just remove and add the same label, without pinging anyone. What is that for?</p>



<a name="224599282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224599282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224599282">(Jan 30 2021 at 18:55)</a>:</h4>
<p>It's so that GitHub treats the PR as updated recently so the next triage person doesn't see that PR.</p>



<a name="224599325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224599325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224599325">(Jan 30 2021 at 18:56)</a>:</h4>
<p>It's annoying to do and kind of a "hacky" approach, but it works :)</p>



<a name="224604377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224604377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224604377">(Jan 30 2021 at 20:50)</a>:</h4>
<p>Ah, i see. So that's done in cases where the author/reviewer isn't pinged on purpose? Is there any guideline for when people get pinged from triage?</p>



<a name="224604522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224604522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224604522">(Jan 30 2021 at 20:54)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-forge/issues/501">forge#501</a> <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="224604767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224604767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224604767">(Jan 30 2021 at 21:00)</a>:</h4>
<p>Ah, thanks!</p>



<a name="224604775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224604775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224604775">(Jan 30 2021 at 21:00)</a>:</h4>
<blockquote>
<p>If the author is a member of a Rust team (..)</p>
</blockquote>
<p>Ah, that explains why the pings have stopped ^^'</p>



<a name="224604797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224604797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224604797">(Jan 30 2021 at 21:01)</a>:</h4>
<p>That PR is derived from this:</p>
<div class="codehilite" data-code-language="Text only"><pre><span></span><code>-&gt; filter prs that aren't active for more than 15 days (by updated at, stupid metric but limited by gh)
-&gt; check label to find the status of the pr (update if necessary by changing the label)
-&gt; if waiting on review:
----&gt; if it has new conflicts, CI failed, or a new review has been made:
---------&gt; update label accordingly to waiting-on-author, ping author
----&gt; don't ping anyone, add the pr to a "report" (explained later)
-&gt; if waiting on author:
----&gt; if it was waiting on author to make changes or resolve conflicts, update the label to waiting-on-review
----&gt; is author a rust team member?
----&gt; if yes, don't png anyone, add the pr to the report
----&gt; if no, ping the author, can add to the report if feel so
-&gt; occasionally (maybe once a month), check for blocked prs: (s-blocked)
---&gt; if it is still blocked, leave as is
---&gt; if it is unblocked (blocked pr is merged), then unblock and update the status accordingly
</code></pre></div>
<p>(It's been posted at various times in this stream by <span class="user-mention silent" data-user-id="120823">DPC</span>.)</p>



<a name="224610212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224610212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224610212">(Jan 30 2021 at 22:54)</a>:</h4>
<p>it is just done so that the pr is marked as "triaged" and the  next person who does triage doesn't pick the same PR</p>



<a name="224610218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Question%3A%20-label%20%2Blabel%20%3F/near/224610218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Question.3A.20-label.20.2Blabel.20.3F.html#224610218">(Jan 30 2021 at 22:54)</a>:</h4>
<p>when it comes to pinging people or leaving a comment there, it isn't needed, because the pr gets updated so it wont show up in other people's filters</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>